Fix AI quote polling terminal state race

Stop polling job status once the stream reports complete, no_quote, or error — and never overwrite an already-terminal UI state with a late Failed to fetch.

1. Why this exists

The AI quote flow has two parallel channels reporting progress to the UI:

1. An event stream the worker emits as it runs (step:start, ai:thinking, complete, …).
2. A polling loop that calls trpc.jobs.getStatus to drain any buffered stream events and check BullMQ job status.

These two channels are not synchronized. The worker can emit a terminal complete event containing pricingQuoteId before BullMQ transitions the job to status: completed. In the previous code, receiving the terminal stream event updated the UI to completed, but the polling loop kept running against a job that was, from BullMQ's perspective, still in flight.

2. The race, visualized

Time flows left → right. The worker (top lane) finishes and writes the quote before BullMQ (middle lane) has flipped the job status. The client poller (bottom lane) keeps firing during that window.

3. What changes

Change A — Every event branch declares whether it is terminal

handleAIQuoteEvent switches from returning void to returning boolean. Non-terminal events (17 of them) return false; the three terminal events return true. A default trailing return false covers any unmatched shape.

case 'complete':
  setState((prev) => ({
    ...prev,
    status: 'completed',
    result: data.result,
  }));
  break;

case 'no_quote':
  setState(...);
  break;

case 'error':
  setState(...);
  break;

case 'complete':
  setState((prev) => ({
    ...prev,
    status: 'completed',
    result: data.result,
  }));
  return true;

case 'no_quote':
  setState(...);
  return true;

case 'error':
  setState(...);
  return true;

Change B — Polling loop exits on terminal events

Inside the drain loop, the return value is captured. On true, the loop clears activeJobRef and returns out of the polling function entirely — no further jobs.getStatus calls will happen for this job.

for (const item of progress.events) {
  if (item.sequence > lastSequence) {
    lastSequence = item.sequence;
    const reachedTerminalState = handleAIQuoteEvent(item.event);
    if (reachedTerminalState) {
      activeJobRef.current = null;
      return;
    }
  }
}

Change C — Catch block refuses to clobber terminal UI states

The polling catch handler now inspects the current state before writing an error. If the UI is already completed or no_quote, the previous state is returned unchanged.

setState((prev) => ({
  ...prev,
  status: 'error',
  error: error.message
    || 'Failed to run AI quoting service',
}));

setState((prev) => {
  if (prev.status === 'completed'
      || prev.status === 'no_quote') {
    return prev;
  }
  return {
    ...prev,
    status: 'error',
    error: error.message
      || 'Failed to run AI quoting service',
  };
});

4. How it works end-to-end

5. What it doesn't change

6. Risks & open questions